Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Light Toy property descriptions #365

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Trevlouw
Copy link

@Trevlouw Trevlouw commented Jan 1, 2025

Description

Describe the changes
Changed the descriptions of the LightShape and LightType properties in Exiled.API.Features.Toys.Light to better represent what they actually do (rather than copy pasted code that wasn't updated when 14.0 came out)

What is the current behavior? (You can also link to an open issue here)
The current descriptions are misleading

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, just changes the descriptions of the properties to help dev's who don't know how to mess with Light's

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

It's much better wording bro trust
@github-actions github-actions bot added the API label Jan 1, 2025
@louis1706 louis1706 added documentation Improvements or additions to documentation and removed API labels Jan 2, 2025
@louis1706 louis1706 merged commit 33e63f8 into ExMod-Team:master Jan 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants