Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect xud address setting leads to empty screen #117

Closed
raladev opened this issue Nov 24, 2020 · 2 comments · May be fixed by #152
Closed

incorrect xud address setting leads to empty screen #117

raladev opened this issue Nov 24, 2020 · 2 comments · May be fixed by #152
Assignees
@rsercano
Labels
bug Something isn't working P2 mid priority

Comments

@raladev
Copy link
Contributor

raladev commented Nov 24, 2020

Steps:

  1. Open Connection page
  2. Enter invalid xud address - ( change port to unavailable one for example)

Actual result:
Empty grey page
Video: https://gofile.io/d/3RR9RZ

Expected result:
Retry button + text err
@raladev raladev added bug Something isn't working P1 top priority P2 mid priority labels Nov 24, 2020
@raladev raladev removed the P1 top priority label Nov 24, 2020
@krrprr
Copy link
Contributor

krrprr commented Nov 24, 2020

Thanks for discovering this @raladev !

We should add an error handling in case the URL cannot be parsed (the port is out of range or the URL is somehow malformed).

@rsercano
Copy link
Contributor

As soon as #115 is merged, I would like to check this too

@kilrau kilrau unassigned kilrau and krrprr Nov 25, 2020
@krrprr krrprr mentioned this issue Nov 25, 2020
Merged
@scorebreaker scorebreaker mentioned this issue Jan 12, 2021
Open
@krrprr krrprr closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
bug Something isn't working P2 mid priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show connection failed error even when url is in bad/illegal format scorebreaker/xud-ui
4 participants
@rsercano @kilrau @krrprr @raladev