Replace eval by require_once for ForwardCompatTypeExtensionTrait

Exercise · Mar 9, 2020 · 98d3456 · 98d3456
1 parent 7a55d73
commit 98d3456
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 18 deletions.
diff --git a/src/Form/TypeExtension/ForwardCompatTypeExtensionTrait.php b/src/Form/TypeExtension/ForwardCompatTypeExtensionTrait.php
@@ -5,24 +5,7 @@
 use Symfony\Component\Form\FormTypeExtensionInterface;
 
 if (method_exists(FormTypeExtensionInterface::class, 'getExtendedTypes')) {
-    eval('
-    namespace Exercise\HTMLPurifierBundle\Form\TypeExtension;
-
-    /**
-     * @internal
-     */
-    trait ForwardCompatTypeExtensionTrait
-    {
-        private static function doGetExtendedTypes(): iterable
-        {
-        }
-
-        public static function getExtendedTypes(): iterable
-        {
-            return self::doGetExtendedTypes();
-        }
-    }
-');
+    require_once __DIR__.'/forward_compat_trait.inc.php';
 } else {
     /**
      * @internal

diff --git a/src/Form/TypeExtension/forward_compat_trait.inc.php b/src/Form/TypeExtension/forward_compat_trait.inc.php
@@ -0,0 +1,18 @@
+<?php
+
+namespace Exercise\HTMLPurifierBundle\Form\TypeExtension;
+
+/**
+ * @internal
+ */
+trait ForwardCompatTypeExtensionTrait
+{
+    private static function doGetExtendedTypes(): iterable
+    {
+    }
+
+    public static function getExtendedTypes(): iterable
+    {
+        return self::doGetExtendedTypes();
+    }
+}