Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Dapp Created Email template. #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dougdesigner
Copy link

No description provided.

Copy link
Contributor

@john-osullivan john-osullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @Lsquared13 This pattern of a file per template, where each file default-exports a builder function, is my gut on how we should set up similar templates going forward. Lets you declare variable names as part of the template, so the template is reusable elsewhere, and provides a clean consumer API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants