Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify function and avoid strtok #2793

Merged
merged 1 commit into from
Oct 18, 2023
Merged

simplify function and avoid strtok #2793

merged 1 commit into from
Oct 18, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Oct 13, 2023

The latter is not thread safe.

The latter is not thread safe.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@ghost
Copy link

ghost commented Oct 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2793 (0450e5c) into main (da58ec9) will increase coverage by 0.01%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
+ Coverage   63.96%   63.98%   +0.01%     
==========================================
  Files         103      103              
  Lines       22344    22324      -20     
  Branches    10835    10826       -9     
==========================================
- Hits        14293    14284       -9     
+ Misses       5828     5824       -4     
+ Partials     2223     2216       -7     
Files Coverage Δ
app/exiv2.cpp 63.11% <44.44%> (+0.38%) ⬆️

@neheb neheb requested a review from kmilos October 17, 2023 19:16
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit a38ec20 into Exiv2:main Oct 18, 2023
48 of 59 checks passed
@neheb neheb deleted the a branch October 18, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants