Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove stringFormat from Error() #2798

Merged
merged 1 commit into from
Oct 19, 2023
Merged

remove stringFormat from Error() #2798

merged 1 commit into from
Oct 19, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Oct 18, 2023

No need.

@ghost
Copy link

ghost commented Oct 18, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@neheb neheb requested a review from kmilos October 18, 2023 19:42
@neheb
remove stringFormat from Error()
5799d36 
No need.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2798 (5799d36) into main (da58ec9) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 11.11%.

@@           Coverage Diff           @@
##             main    #2798   +/-   ##
=======================================
  Coverage   63.96%   63.96%           
=======================================
  Files         103      103           
  Lines       22344    22344           
  Branches    10835    10835           
=======================================
  Hits        14293    14293           
  Misses       5828     5828           
  Partials     2223     2223
Files Coverage Δ
src/webpimage.cpp 49.89% <100.00%> (ø)
src/rafimage.cpp 20.29% <0.00%> (ø)
src/basicio.cpp 50.46% <0.00%> (ø)

kmilos
kmilos approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit b1225ca into Exiv2:main Oct 19, 2023
42 of 59 checks passed
@neheb neheb deleted the em branch October 19, 2023 17:05
@kmilos
Copy link
Collaborator

kmilos commented Oct 20, 2023

@Mergifyio backport 0.28.x

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023 •
edited
Loading

backport 0.28.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmilos kmilos kmilos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @kmilos