cmake: restore a "exiv2lib" target #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
=======================================
Coverage 63.88% 63.88%
=======================================
Files 103 103
Lines 22381 22381
Branches 10873 10873
=======================================
Hits 14297 14297
Misses 5862 5862
Partials 2222 2222 ☔ View full report in Codecov by Sentry. |
pinotree
force-pushed
the
cmake-target-compat
branch
2 times, most recently
from
65322f3 to
4f6d0b8
Compare
pinotree
force-pushed
the
cmake-target-compat
branch
from
4f6d0b8 to
e793201
Compare
Commit a8c3455 and commit eb05551 changed the target of the exiv2 library ("exiv2lib"), exporting it in the "Exiv2" namespace, so making it usable as "Exiv2::exiv2lib" instead. An ALIAS to "exiv2lib" was added, however cmake does not install or export ALIAS targets [1]. Hence, restore compatibility with the existing cmake users of exiv2: manually create an ALIAS target in the cmake config files after all the targets are loaded and checked. [1] https://cmake.org/cmake/help/latest/command/add_library.html
pinotree
force-pushed
the
cmake-target-compat
branch
from
e793201 to
1d01500
Compare
|
ping @Ryanf55 |
This is an issue if we lose the original target name; those changes were not intended to be breaking. But, I'm not sure this is the right fix. I can try an alternative fix. The targets are supposed to be generated automatically by the config script Once we get the fix in, It would be prudent to add a test in CI to verify the targets the users expect exist. |
neheb
approved these changes
Dec 10, 2023
|
Would be possible to backport this to the |
|
@Mergifyio backport 0.28.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a8c3455 and commit eb05551 changed the target of the exiv2 library (
exiv2lib), exporting it in theExiv2namespace, so making it usable asExiv2::exiv2libinstead. AnALIAStoexiv2libwas added, however cmake does not install or exportALIAStargets [1].Hence, restore compatibility with the existing cmake users of exiv2: manually create an
ALIAStarget in the cmake config files after all the targets are loaded and checked.[1] https://cmake.org/cmake/help/latest/command/add_library.html
Tested with digikam and photoqt, which refer to
exiv2libin their cmake build systems.