cmake: restore a "exiv2lib" target (backport #2832) #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Commit a8c3455 and commit eb05551 changed the target of the exiv2 library ("exiv2lib"), exporting it in the "Exiv2" namespace, so making it usable as "Exiv2::exiv2lib" instead. An ALIAS to "exiv2lib" was added, however cmake does not install or export ALIAS targets [1]. Hence, restore compatibility with the existing cmake users of exiv2: manually create an ALIAS target in the cmake config files after all the targets are loaded and checked. [1] https://cmake.org/cmake/help/latest/command/add_library.html (cherry picked from commit 130064d)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 0.28.x #2870 +/- ##
==========================================
- Coverage 63.99% 63.98% -0.02%
==========================================
Files 103 103
Lines 22338 22340 +2
Branches 10821 10822 +1
==========================================
- Hits 14296 14294 -2
- Misses 5818 5822 +4
Partials 2224 2224 ☔ View full report in Codecov by Sentry. |
neheb
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2832 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com