Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid testing __cpp_lib_format #3124

Merged
merged 1 commit into from
Jan 17, 2025
Merged

avoid testing __cpp_lib_format #3124

merged 1 commit into from
Jan 17, 2025

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jan 15, 2025

It was introduced late into LLVM's libc++. Test for the function directly.

It was introduced late into LLVM's libc++. Test for the function
directly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
Copy link
Collaborator Author

neheb commented Jan 15, 2025

testing locally, this works.

The CIFuzz CI needs to be set to C++20 elsewhere looks like because of -stdlib=libc++

@kevinbackhouse
Copy link
Collaborator

@neheb: sorry, I only just noticed this PR.

@kevinbackhouse
Copy link
Collaborator

I created a PR to use C++20 in the OSS-Fuzz build: google/oss-fuzz#12946

@neheb neheb merged commit 46925ed into Exiv2:main Jan 17, 2025
58 of 59 checks passed
@neheb neheb deleted the 1 branch January 17, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants