[HOLD for payment 2025-01-02] [Medium] Create Trip Details

[stitesExpensify]

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.lgcmthyxnpmx

This issue is for creating a new trip details modal:

A new page, TravelDetails.ts will be created in src/pages/Travel:

• It will receive the transactionID as a route parameter, which we’ll use to retrieve the full transaction via withOnyx, and, from there, we’ll display the travel-related information
• It will include a HeaderWithBackButton component with either “Flight Details” or “Hotel Details” as the title, depending on whether it is a flight or a hotel booking. Similarly, it will either display a plane or a hotel icon, which we will pass to HeaderWithBackButton through the new parameter added here. - - For other travel-related expenses (Trains, car rental), the title will default to the generic “Travel Details” and the plane icon (we can change this down the line).
• The itinerary and confirmation number elements will be displayed using the existing MenuItemWithTopDescription component with the interactive parameter set to false. For the itinerary’s arrow for flights, we can use the ➜ unicode character.
• A new component, TripDetailsMenuItem will be created to display the detailed itinerary (with the airline, airports, etc). It will receive the travel-related information from the transaction as a parameter and will be formatted as displayed above. Since the user can’t interact with the element in any way, there is no need for further considerations.
• The trip support link will be displayed using the existing MenuItem component, passing our phone icon as the icon. On click, it will take the user to Spotnana’s support page.

Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx

Issue Owner

Current Issue Owner: @twisterdotcom

[cdOut]

Hello, I’m Tymoteusz from Software Mansion, the expert agency, and I’d like to work on this task.

[twisterdotcom]

Adding a C+ here for Travel reviews: @shubham1206agra

[twisterdotcom]

Only assigned on Friday. We can give them a day here Melvin.

[melvin-bot]

@twisterdotcom, @shubham1206agra, @cdOut Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[twisterdotcom]

Are we waiting on anything internal here?

[cdOut]

No, Im working on creating a draft PR for this issue by tomorrow.

[twisterdotcom]

Nice, draft PR is in!

[twisterdotcom]

Same Q, answer in one place is fine: #37824 (comment)

[cdOut]

@twisterdotcom both PRs are linked, we are currently waiting for the backend implementation, since right now we basically work on dummy data.

From what I know it has been decided that we will hold off on these PRs with further reviews until we get backend access, you can refer to this decision here.

[twisterdotcom]

Still waiting on webhooks.

[blazejkustra]

We can close this issue, as PR was merged last week.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [vip-travel] Create Trip Details Screen #52823

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @blazejkustra is from an agency-contributor and not due payment
• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@twisterdotcom, @stitesExpensify, @blazejkustra, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

Payment Summary:

• @blazejkustra does not require payment (Contractor)
• @shubham1206agra paid $500 via Upwork here

[shubham1206agra]

@twisterdotcom Offer accepted