[$250] Hybrid App Android : Showing a Fix banner when there is nothing to fix

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jliexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727237125506689

Action Performed:

1. SmartScan receipt with a field that falls outside the Workspace rules (e.g. over $10 USD on Coffee Workspace)
2. Confirm that it gets added to current unsubmitted Report under the Workspace
3. Click on expense and change field (e.g. edit expense amount to reflect $10 USD)
4. Observe the Fix banner on Report
5. Exit app and open again
6. Observe the Fix banner on Report

Expected Result:

Fix Banner replaced with the status of the report or the next step displayed

Actual Result:

Fix banner displayed even after applying the fix

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

screen-20240925-130712.mp4

az_recorder_20240925_154938.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839400983690827454
• Upwork Job ID: 1839400983690827454
• Last Price Increase: 2024-09-26

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839400983690827454

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

@sakluger, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

[sakluger]

Thanks @JKobrynski!

[JKobrynski]

It actually happens on all platforms:

Mobile web:

web-compressed.mov

iOS:

ios-compressed.mp4

[JKobrynski]

I think the reason why this is happening might be that the UpdateMoneyRequestAmountAndCurrency API command doesn't update reportNextStep_<id> Onyx entry. After the amount is changed to a value below the limit, the Onyx entry still stores the message that was shown for an invalid amount. What do you think? Could it be done on the backend?

[JKobrynski]

@sakluger have you had the chance to take a look at my question above? 🙏

[sakluger]

I'll ask our internal engineers if they can help: https://expensify.slack.com/archives/C036QM0SLJK/p1728317833800759

[melvin-bot]

@sakluger @rushatgabhane @JKobrynski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[sakluger]

No updates.

[JKobrynski]

Hey! FYI I'm back from the sick leave, I'll continue working on this issue

[JKobrynski]

Seems like for this specific violation flow, there is a bug in the next steps logic as the cache for the expense is not recomputed, I will need to follow up on this one

Do you think there is anything that can be done on the frontend or is this backend only?

CC: @mountiny

[JKobrynski]

@mountiny kindly bump 🙏

[mountiny]

@JKobrynski this is backend issue

[mountiny]

Havent got around yet

[mountiny]

Created a follow up that should hopefully fix this issue with cache

[mountiny]

It requires more debugging but I havent had time

[mountiny]

Same,

[mountiny]

@dangrous is leading the way on fixing this in the backend by making sure the violations are always recomputed

[dangrous]

Hi! Yes, this should hopefully be fixed by https://github.com/Expensify/Web-Expensify/pull/44527. I need to figure out how to test SmartScan locally, otherwise we can just hold and retest it when complete.

[dangrous]

Fix PR is merged, not yet deployed. Hopefully we can retest and close this soon!

[dangrous]

Fix is on staging, can we retest this and close?

[sakluger]

I asked for a retest: https://expensify.slack.com/archives/C9YU7BX5M/p1734621671015609

[dangrous]

An updated version of the fix for this is now in review - the original fix was unfortunately reverted so we don't need the retest yet... Given the holidays though the timing might work out either way?

[dangrous]

Fix in review, I need to respond to comments now that I'm back from holiday break. Soon!

[dangrous]

The fix is ready, but we're debating a bit some performance tradeoffs that are seemingly required for the fix. Ideally we'll have resolution soon though

[dangrous]

Getting there! Both PRs that should fix this have been moved forward (discussion complete) and we should be nearly there.