Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't see the "Restore stashed login option" when supportal'd in to a customer's account #54835

Open
1 of 8 tasks
m-natarajan opened this issue Jan 6, 2025 · 12 comments
Open
1 of 8 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 6, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @zsgreenwald
Slack conversation (hyperlinked to channel name): quality

Action Performed:

Pre-Condition: Must be supportalled into a number of users accounts beforehand

  1. Login as a support agent in to a customer account
  2. Navigate to settings

Expected Result:

"Restore stashed login option" displayed in settings

Actual Result:

"Restore stashed login option" not displayed in settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (8)

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

Triggered auto assignment to @rlinoz (AutoAssignerNewDotQuality)

Copy link

melvin-bot bot commented Jan 6, 2025

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 6, 2025
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@rlinoz
Copy link
Contributor

rlinoz commented Jan 6, 2025

Hmm weird, I can see it both in prod and staging, you also should not be seeing the Signout button

@jliexpensify
Copy link
Contributor

Yeah this is weird, I asked Greeny to share the specific email and I think we should check their account.

@jliexpensify
Copy link
Contributor

I'm unable to repro for the customer's account on my side:

2025-01-07_14-36-56.mp4

Current User : lee@taethni.com
Account ID : 18789218

@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Jan 7, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 9, 2025
@jliexpensify jliexpensify changed the title Don't see the "Restore stached login option" when supportal'd in to a customer's account Don't see the "Restore stashed login option" when supportal'd in to a customer's account Jan 9, 2025
@rlinoz
Copy link
Contributor

rlinoz commented Jan 9, 2025

Repro steps from the thread: https://expensify.slack.com/archives/C05LX9D6E07/p1736183628048589

  1. Logout from NewDot
  2. Go to supportal
  3. Log into user's account
  4. Select New Expensify
  5. Verify there is no Restore stashed login option

@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2025
@jliexpensify
Copy link
Contributor

jliexpensify commented Jan 9, 2025

This will need to be handled internally, right @rlinoz? Right now, we log into Supportal, then select the New Expensify option to get into someone's account - but this feels like we'd need to build out a general stashed login button in ND, like what we see in Classic.

@jliexpensify jliexpensify added Internal Requires API changes or must be handled by Expensify staff and removed Needs Reproduction Reproducible steps needed labels Jan 9, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2025
@jliexpensify
Copy link
Contributor

@rlinoz I've added the Internal label: would you be taking this one on?

@melvin-bot melvin-bot bot removed the Overdue label Jan 13, 2025
@rlinoz
Copy link
Contributor

rlinoz commented Jan 13, 2025

Yeah, since this is a medium priority I can keep it and work on it as other issues I have might get blocked.

@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2025
@rlinoz
Copy link
Contributor

rlinoz commented Jan 16, 2025

I think I will be able to take a look at this tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label Jan 16, 2025
@rlinoz
Copy link
Contributor

rlinoz commented Jan 16, 2025

Ok, I am looking at the code and this is a pretty simple fix, but I am starting to think that this is not a bug since you are gonna be signed out of the app, there is no session to restore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
Development

No branches or pull requests

4 participants