Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: room chat - whisper displays 1 mention when 2 mentions are send in specific way #804

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NJ-2020
Copy link
Contributor

@NJ-2020 NJ-2020 commented Sep 24, 2024

Fixed Issues

$ Expensify/App#46299

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?
  3. Go to Expensify App
  4. Tap on a room chat
  5. Mention 2 user with minus sign in between i.e #user1-#user2
  6. Verify that whisper display 2 user

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?
  3. Same as Tests

@NJ-2020 NJ-2020 requested a review from a team as a code owner September 24, 2024 09:15
@melvin-bot melvin-bot bot requested review from rlinoz and removed request for a team September 24, 2024 09:16
@rojiphil
Copy link

rojiphil commented Sep 24, 2024

@NJ-2020 Can you please fill in the PR Author Checklist and follow the contributing guidelines as mentioned here and here.
The PR Author Checklist must be the contents of the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants