Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package-lock #768

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Update package-lock #768

merged 1 commit into from
Jul 30, 2024

Conversation

srikarparsi
Copy link
Contributor

@srikarparsi srikarparsi commented Jul 30, 2024 •
edited
Loading

Updating package-lock by running npm i after this change

Fixed Issues

$ #766

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?
    N/A

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?
    N/A

@srikarparsi srikarparsi requested a review from a team as a code owner July 30, 2024 22:19
@srikarparsi srikarparsi self-assigned this Jul 30, 2024
@melvin-bot melvin-bot bot requested review from deetergp and removed request for a team July 30, 2024 22:19
neil-marcellini
neil-marcellini approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this is a reasonable part of updating @typescript-eslint, and somehow it got missed, maybe due to the conflicts. Next time I'll be sure to run npm i in the original PR.

@srikarparsi srikarparsi merged commit 1fdcc05 into main Jul 30, 2024
6 checks passed
@srikarparsi srikarparsi deleted the srikar-updatePackageLock branch July 30, 2024 22:30
@github-actions GitHub Actions
Copy link

🚀Published to npm in v2.0.63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-marcellini neil-marcellini neil-marcellini approved these changes

@deetergp deetergp Awaiting requested review from deetergp

Assignees

@srikarparsi srikarparsi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikarparsi @neil-marcellini