Add handling short mentions tags to ExpensiMark #824
+72
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Kicu
force-pushed
the
kicu/38025-short-mentions
branch
from
275cc20 to
c9e41a1
Compare
CLABotify
added a commit
to Expensify/CLA
that referenced
this pull request
Dec 30, 2024
Kicu
force-pushed
the
kicu/38025-short-mentions
branch
from
c9e41a1 to
bb4cc97
Compare
Kicu
force-pushed
the
kicu/38025-short-mentions
branch
from
e7b887c to
206d18c
Compare
Kicu
changed the title
Kicu
changed the title
Kicu
force-pushed
the
kicu/38025-short-mentions
branch
from
206d18c to
f7e27c7
Compare
melvin-bot
bot
requested review from
arosiclair
and removed request for
a team
arosiclair
requested review from
puneetlath and
thienlnam
and removed request for
arosiclair
|
Commenting here for assignment. |
Comment on lines
1671
to
1681
| test('Test for email with test+1@gmail.com@gmail.com', () => { | ||
| const testString = 'test+1@gmail.com@gmail.com'; | ||
| const resultString = '<a href="mailto:test+1@gmail.com">test+1@gmail.com</a>@gmail.com'; | ||
| const resultString = '<a href="mailto:test+1@gmail.com">test+1@gmail.com</a><mention-short>@gmail.com</mention-short>'; | ||
| expect(parser.replace(testString)).toBe(resultString); | ||
| }); | ||
|
|
||
| test('Test for email with test@gmail.com@gmail.com', () => { | ||
| const testString = 'test@gmail.com@gmail.com'; | ||
| const resultString = '<a href="mailto:test@gmail.com">test@gmail.com</a>@gmail.com'; | ||
| const resultString = '<a href="mailto:test@gmail.com">test@gmail.com</a><mention-short>@gmail.com</mention-short>'; | ||
| expect(parser.replace(testString)).toBe(resultString); | ||
| }); |
There was a problem hiding this comment.
This might be invalid emails after all. See https://stackoverflow.com/questions/12355858/how-many-symbol-can-be-in-an-email-address
There was a problem hiding this comment.
yeah indeed test+1@gmail.com@gmail.com looks like invalid email.
But I thought the reasoning was that the parser should treat it as a separate email (1st part) and then just text @gmail.com which now becomes a short mention.
Do you want me to change anything related to this?
Draft
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is part of allowing to style and highlight short-mentions inside live-markdown when user is writing/editing their message. More details here: Expensify/App#38025 (comment)
The purpose of this PR is to add handling of (possible) short mention tags to ExpensiMark.
In this PR we define "short-mention" as anything after
@character that would be a valid email prefix.Examples:
Why "possible" short mentions
The only way for us to actually render short-mentions inside
react-native-live-markdown(and other code using ExpensiMark) is to somehow have the list of all possible user logins, and then checking whether the user typed mention matches any of them.However such list should not and cannot be shared in any way to ExpensiMark, as this is just a simple parser. But we still need to some kind of output from ExpensiMark, to understand that there are mentions inside parsed text, so that we can later try and match them to user onyx data.
This creates some changes in how ExpensiMark interprets text, because something that in the past would be considered just normal text, might now be a short mention.
Example of parser output that changed (based on tests)
test@gmail.com@gmail.com<a href=\"mailto:test@gmail.com\">test@gmail.com</a>@gmail.com<a href=\"mailto:test@gmail.com\">test@gmail.com</a><mention-short>@gmail.com</mention-short>- @gmail.com is a correct mentionIn total I had to edit ~5 tests, all the other ones are passing correctly.
CC @puneetlath @tomekzaw @BartoszGrajdek
Fixed Issues
$ Expensify/App#38025
Tests
I made sure all existing unit tests pass, and added specific tests for short mentions
QA