Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs improvements #299

Open
4 of 6 tasks
jordibc opened this issue Apr 10, 2018 · 3 comments
Open
4 of 6 tasks

Logs improvements #299

jordibc opened this issue Apr 10, 2018 · 3 comments
Assignees

Comments

@jordibc
Copy link
Contributor

jordibc commented Apr 10, 2018

  • Create a LogDialog component that encapsultes the log view.
  • Have a paging mechanism so more logs can be shown.
  • Show 'Loading...' at the beginning instead of the previous layout
  • Be more specific with the logging. Describe the exact actions
  • When displaying logs for a specific dataset, we shouldn't display the dataset in each entry. Probably better to display on the header -> we keep it as there could be several datasets affected by an action, and we want to see them all (even if they are not selected)
  • Only log a change in the sharing settings if there are actual changes -> see note below
@jordibc jordibc self-assigned this Apr 10, 2018
@adrianq adrianq added the ready label Apr 10, 2018
@adrianq
Copy link
Member

adrianq commented Apr 10, 2018

As discussed, @jordibc will work on the paging mechanism and create a PR just for that. Jordi if you can also add the third task (Show 'Loading' on init) to that PR it would be great. I guess it should be pretty straight-forward

@adrianq adrianq added in progress and removed ready labels Apr 11, 2018
@jordibc
Copy link
Contributor Author

jordibc commented Apr 24, 2018

To only log a change in the sharing settings, it seems we would have to modify d2-ui/lib/sharing/SharingDialog.component.js:98:

        this.props.onRequestClose(_sharing2.default.getState());
->
        this.props.onRequestClose(_sharing2.default.getState(), this.status.sharingChanged);

with a new variable sharingChanged that is set to true if the sharing properties actually changed.

Then, in dataset-configuration/src/DataSets/DataSets.component.js:394:

                    onRequestClose={() => {
->
                    onRequestClose={(state, sharingChanged) => {

and only call log() if sharingChanged.

@tokland
Copy link
Collaborator

tokland commented May 22, 2018

  • Sharing: Move logging to parent component, so it logs only once when dialog is closed.

@adrianq adrianq added ready and removed testing labels May 24, 2018
@tokland tokland removed the ready label May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants