Skip to content

Commit

Permalink
[fix]: double-click navigation crash (#98)
Browse files Browse the repository at this point in the history
  • Loading branch information
@F0x1d
F0x1d committed Feb 2, 2024
1 parent 49420d9 commit 3dcc5a1
Show file tree
Hide file tree
Showing 4 changed files with 99 additions and 94 deletions.
49 changes: 24 additions & 25 deletions app/src/main/res/navigation/crashes.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,22 @@
<fragment
android:id="@+id/crashesFragment"
android:name="com.f0x1d.logfox.ui.fragment.crashes.list.CrashesFragment"
android:label="CrashesFragment" >
<action
android:id="@+id/action_crashesFragment_to_crashDetailsFragment"
app:destination="@id/crashDetailsFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim"/>
<action
android:id="@+id/action_crashesFragment_to_appCrashesFragment"
app:destination="@id/appCrashesFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim"/>
</fragment>
android:label="CrashesFragment" />
<action
android:id="@+id/action_crashesFragment_to_crashDetailsFragment"
app:destination="@id/crashDetailsFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim"/>
<action
android:id="@+id/action_crashesFragment_to_appCrashesFragment"
app:destination="@id/appCrashesFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim"/>

<fragment
android:id="@+id/appCrashesFragment"
android:name="com.f0x1d.logfox.ui.fragment.crashes.list.AppCrashesFragment"
Expand All @@ -34,20 +34,19 @@
android:name="app_name"
app:argType="string"
app:nullable="true" />

<action
android:id="@+id/action_appCrashesFragment_to_crashDetailsFragment"
app:destination="@id/crashDetailsFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim"/>
</fragment>
<action
android:id="@+id/action_appCrashesFragment_to_crashDetailsFragment"
app:destination="@id/crashDetailsFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim"/>

<fragment
android:id="@+id/crashDetailsFragment"
android:name="com.f0x1d.logfox.ui.fragment.crashes.CrashDetailsFragment"
android:label="CrashDetailsFragment">

<argument
android:name="crash_id"
app:argType="long"
Expand Down
71 changes: 37 additions & 34 deletions app/src/main/res/navigation/logs.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,25 @@
app:argType="android.net.Uri"
android:defaultValue="@null"
app:nullable="true" />

<action
android:id="@+id/action_logsFragment_to_logsExtendedCopyFragment"
app:destination="@id/logsExtendedCopyFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_logsFragment_to_searchBottomSheet"
app:destination="@id/searchBottomSheet" />
<action
android:id="@+id/action_logsFragment_to_filtersFragment"
app:destination="@id/filtersFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
</fragment>
<action
android:id="@+id/action_logsFragment_to_logsExtendedCopyFragment"
app:destination="@id/logsExtendedCopyFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_logsFragment_to_searchBottomSheet"
app:destination="@id/searchBottomSheet" />
<action
android:id="@+id/action_logsFragment_to_filtersFragment"
app:destination="@id/filtersFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />

<fragment
android:id="@+id/logsExtendedCopyFragment"
android:name="com.f0x1d.logfox.ui.fragment.logs.LogsExtendedCopyFragment"
Expand All @@ -40,22 +40,24 @@
android:name="content"
app:argType="string" />
</fragment>

<dialog
android:id="@+id/searchBottomSheet"
android:name="com.f0x1d.logfox.ui.dialog.SearchBottomSheet"
android:label="SearchBottomSheet" />

<fragment
android:id="@+id/filtersFragment"
android:name="com.f0x1d.logfox.ui.fragment.filters.FiltersFragment"
android:label="FiltersFragment" >
<action
android:id="@+id/action_filtersFragment_to_editFilterFragment"
app:destination="@id/editFilterFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
</fragment>
android:label="FiltersFragment" />
<action
android:id="@+id/action_filtersFragment_to_editFilterFragment"
app:destination="@id/editFilterFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />

<fragment
android:id="@+id/editFilterFragment"
android:name="com.f0x1d.logfox.ui.fragment.filters.EditFilterFragment"
Expand All @@ -64,14 +66,15 @@
android:name="filter_id"
app:argType="long"
android:defaultValue="-1L" />
<action
android:id="@+id/action_editFilterFragment_to_chooseAppFragment"
app:destination="@id/chooseAppFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
</fragment>
<action
android:id="@+id/action_editFilterFragment_to_chooseAppFragment"
app:destination="@id/chooseAppFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />

<fragment
android:id="@+id/chooseAppFragment"
android:name="com.f0x1d.logfox.ui.fragment.filters.ChooseAppFragment"
Expand Down
10 changes: 5 additions & 5 deletions app/src/main/res/navigation/recordings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
<fragment
android:id="@+id/recordingsFragment"
android:name="com.f0x1d.logfox.ui.fragment.RecordingsFragment"
android:label="RecordingsFragment" >
<action
android:id="@+id/action_recordingsFragment_to_recordingBottomSheet"
app:destination="@id/recordingBottomSheet" />
</fragment>
android:label="RecordingsFragment" />
<action
android:id="@+id/action_recordingsFragment_to_recordingBottomSheet"
app:destination="@id/recordingBottomSheet" />

<dialog
android:id="@+id/recordingBottomSheet"
android:name="com.f0x1d.logfox.ui.dialog.RecordingBottomSheet"
Expand Down
63 changes: 33 additions & 30 deletions app/src/main/res/navigation/settings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,48 +7,51 @@
<fragment
android:id="@+id/settingsMenuFragment"
android:name="com.f0x1d.logfox.ui.fragment.settings.SettingsMenuFragment"
android:label="SettingsMenuFragment" >
<action
android:id="@+id/action_settingsMenuFragment_to_settingsUIFragment"
app:destination="@id/settingsUIFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_settingsMenuFragment_to_settingsServiceFragment"
app:destination="@id/settingsServiceFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_settingsMenuFragment_to_settingsNotificationsFragment"
app:destination="@id/settingsNotificationsFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_settingsMenuFragment_to_settingsCrashesFragment"
app:destination="@id/settingsCrashesFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
</fragment>
android:label="SettingsMenuFragment" />
<action
android:id="@+id/action_settingsMenuFragment_to_settingsUIFragment"
app:destination="@id/settingsUIFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_settingsMenuFragment_to_settingsServiceFragment"
app:destination="@id/settingsServiceFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_settingsMenuFragment_to_settingsNotificationsFragment"
app:destination="@id/settingsNotificationsFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />
<action
android:id="@+id/action_settingsMenuFragment_to_settingsCrashesFragment"
app:destination="@id/settingsCrashesFragment"
app:enterAnim="@anim/nav_default_enter_anim"
app:exitAnim="@anim/nav_default_exit_anim"
app:popEnterAnim="@anim/nav_default_pop_enter_anim"
app:popExitAnim="@anim/nav_default_pop_exit_anim" />

<fragment
android:id="@+id/settingsUIFragment"
android:name="com.f0x1d.logfox.ui.fragment.settings.SettingsUIFragment"
android:label="SettingsUIFragment" />

<fragment
android:id="@+id/settingsServiceFragment"
android:name="com.f0x1d.logfox.ui.fragment.settings.SettingsServiceFragment"
android:label="SettingsServiceFragment" />

<fragment
android:id="@+id/settingsNotificationsFragment"
android:name="com.f0x1d.logfox.ui.fragment.settings.SettingsNotificationsFragment"
android:label="SettingsNotificationsFragment" />

<fragment
android:id="@+id/settingsCrashesFragment"
android:name="com.f0x1d.logfox.ui.fragment.settings.SettingsCrashesFragment"
Expand Down

0 comments on commit 3dcc5a1

Please sign in to comment.