Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Landing Page Header/Menu #121

Open
CSchmitz81 opened this issue Aug 21, 2019 · 3 comments · Fixed by #126
Open

Update Landing Page Header/Menu #121

CSchmitz81 opened this issue Aug 21, 2019 · 3 comments · Fixed by #126

Comments

@CSchmitz81
Copy link
Member

CSchmitz81 commented Aug 21, 2019

Update the landing page header bar (desktop) and menu (mobile) to match the comps. For desktop this means removing the tabs and just showing links. The link for the current page should be highlighted in green (as shown for the "Overview" link in the comp). If there's not enough room to show the "Collaboration Tree" label and links on the same row, they should be split into separate rows.

For the mobile, update the top bar style to match the comps. There's no comp showing the menu, it should be updated so the style is consistent with the updated site.

If possible, hide the top bar when the user scrolls down and reveal it when the user starts scrolling back up, for both desktop and mobile. If that's not possible, keep the top bar in place at all times.

Please base your changes on the develop-landing-page branch.

@CSchmitz81
Copy link
Member Author

Hey @KyleHefner, I just wanted to check in to see if you've made any progress on this. I haven't seen any responses on the PR (#126) for the past couple months, so I wanted to see if I should free this up for someone else to work on.

@CSchmitz81 CSchmitz81 linked a pull request May 21, 2020 that will close this issue
CSchmitz81 added a commit that referenced this issue May 21, 2020
…eader-#121

Develop landing page landing page header #121
@CSchmitz81
Copy link
Member Author

Progress has stalled on PR #126. Went ahead and merged it so the partial implementation can be included. Additional work should pick up from where #126 left off, taking into consideration the comments from #126.

CSchmitz81 added a commit that referenced this issue May 21, 2020
…ding-page-header-#121

Revert "Develop landing page landing page header #121"
@CSchmitz81
Copy link
Member Author

CSchmitz81 commented May 21, 2020

Reverted merging #126 because it caused regressions in the layout. The branch was restored, so work should continue in that branch (develop-landing-page-landing-page-header-#121), including resolving these regressions.

CSchmitz81 added a commit that referenced this issue May 21, 2020
…-page-header-#121

# Conflicts:
#	src/ctree-app/ctree-landing.html
@mmannava mmannava self-assigned this Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants