added config item f5_http_rps_throttle and a proper HTTP rps iRule #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please close this PR and resubmit to F5Networks:1.0. I will merge from 1.0 to liberty -> mitaka -> master. |
mattgreene
reviewed
Sep 29, 2016
| @@ -588,6 +588,21 @@ f5_common_external_networks = True | |||
| # l3_binding_static_mappings = 'subnet_a':[('port_a','device_a'),('port_b','device_b')], 'subnet_b':[('port_c','device_a'),('port_d','device_b')] | |||
| # | |||
| # | |||
| # f5_http_rps_throttle | |||
There was a problem hiding this comment.
Suggest a more descriptive title, such as:
HTTP request rate-limiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattgreene
What issues does this address?
Fixes #127
WIP #127
...
What's this change do?
Adds a configuration item 'f5_http_rps_throttle' which is a Boolean and defaults to False.
Adds a valid HTTP RPS iRule. The iRule properly keeps the RPS count per virtual server. The previous iRule would never engage the throttle because of a mistake in logic. The new iRule is also CMP compliant.
If the 'f5_http_rps_throttle' config setting is set to True for a VIP with a connection limit > 0, the new iRule will be created for the tenant and associated with the virtual server for the VIP.
If the 'f5_http_rps_throttle' config setting is set to False, the default, on a VIP with a connection limit > 0, the virtaul server will simply have the connection limit set to the VIP connection limit.
Where should the reviewer start?
Start an LBaaSv1 agent with 'f5_http_rps_throttle' set to False. Set a VIP connection limit > 0 and confirm the virtual server has the connection limit set.
Start an LBaasv1 agent with 'f5_http_rps_throttle' set to True. Set a VIP connection limit > 0 and confirm that the tenant iRule was created and associated with the appropriate vip.