added config item f5_http_rps_throttle and a proper HTTP rps iRule #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@<reviewer_id>
What issues does this address?
Fixes #127
WIP #127
...
What's this change do?
Creates a agent config entry to toggle if VIP connection limit should be an L4 connection limit or an L7 HTTP rps limit for HTTP VIPs. By default the VIP will stick to current tested L4 connection limits.
If the agent config set the f5_http_rps_throttle setting to True, a new iRule is used to implement the HTTP rps throttle. The new iRule was tested on 11.x and 12.x and is CMP friendly. The old iRule did not work. It never engaged a throttle limit.
Where should the reviewer start?
Create an LBaaSv1 Pool and VIP.with no changes to the agent config. On the VIP set the protocol to HTTP and connection_limit attribute > 1. Confirm the BIG-IP virtual server connection limit attribute tracks the VIP connect_limit attribue.
Create and LBaaSv1 Pool and VIP with the f5_http_rps_throttle = True set in the agent config. On the VIP set the protocol to HTTP connection_limit attribute > 1. Confirm that the agent created the HTTP throttle iRule in the client folder and the iRule was associated with the BIG-IP virtual server created for the VIP.
Any background context?
The only iRule did not work as intended.