Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent formatting #73

Open
maxgerber opened this issue Nov 20, 2018 · 1 comment
Open

Inconsistent formatting #73

maxgerber opened this issue Nov 20, 2018 · 1 comment

Comments

@maxgerber
Copy link

Me again!

As I was looking through all the repos, I also noticed that some of the merged code has inconsistent formatting. This suggests to me that not everyone's linters are set up correctly. Can you all double-check that your linters are working, and that eslint is autofixing on save, so that you don't have to worry about things extra spaces, incorrect indentation, or extra lines in your future PRs. Dedicating a little time to this now will make your code neater, easier to read, and more professional in the long run.

Thanks,
Max
@InassTubail
Copy link
Collaborator

There was some problem in linter, but now we fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxgerber @InassTubail