Add initial signposting headers #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekSuchanek
force-pushed
the
feature/signposting
branch
from
4211e22 to
9fd20d0
Compare
MarekSuchanek
changed the title
MarekSuchanek
approved these changes
Mar 19, 2024
|
@kburger rebased and fixed CI, OK for me as an initial version of signposting, can I squash-merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of signposting headers. Nothing special right now, and a lot of decisions still have to be made.
The current logic is added to the controller directly, but it could just as easily be moved to a filter. Up for discussion.