Update to the recommended 'defaults' value for browserslist #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mint-thompson
approved these changes
Sep 22, 2023
cmoesel
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
This PR updates the
browserslistinpackage.jsonto just specify the default values. This is what the browserslists library documents as best practice, so I think it makes sense for us to use this. I think this is changing how the code is built, which is why the error is not seen anymore. Using the default does exclude some old browsers, though, so if you don't think this is a sufficient solution, let me know.To test this, build the app and serve the production build and test that the two examples convert FSH to FHIR successfully.