Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variations on start and build scripts for Windows systems #155

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

mint-thompson
Copy link
Collaborator

These scripts set an environment variable before invoking react-app-rewired. The syntax for doing this is different on Windows systems. Two new scripts are defined to make these actions available to Windows users.

These scripts set an environment variable before invoking
react-app-rewired. The syntax for doing this is different on Windows
systems. Two new scripts are defined to make these actions available to
Windows users.
jafeltra
jafeltra previously approved these changes Mar 22, 2024
@jafeltra
Copy link
Collaborator

I tried using start:win on my Mac and it does not work. So I guess we can discuss whether we want to add cross-env and use that in one script or keep both.

@cmoesel
Copy link
Member

cmoesel commented Mar 25, 2024

I say let's use cross-env. It's designed exactly for this purpose and is super easy to use.

@cmoesel
Copy link
Member

cmoesel commented Mar 29, 2024

I had some time, so I switched this over to using cross-env. It still works on Mac. At this point, we can only assume it works on Windows (if there is truth in advertising).

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, Mint and Chris. This looks great!

@cmoesel cmoesel merged commit faa9520 into master Apr 1, 2024
4 checks passed
@cmoesel cmoesel deleted the scripts-for-windows branch April 1, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants