console debug log level #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(onGoFSHClick).toHaveBeenCalledTimes(2); | ||
| expect(onGoFSHClick).toHaveBeenCalledWith('', true); // Loading | ||
| expect(onGoFSHClick).toHaveBeenCalledWith(simpleFsh, false); | ||
| }); | ||
| }); | ||
|
|
||
| it('calls GoFSH with the logger level debug if the configuration checkbox is checked', async () => { |
There was a problem hiding this comment.
Should there also be a test for running SUSHI with debug logging enabled?
cmoesel
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
This is a nice feature! I've reviewed the code and tested it manually. Debug logging works for both SUSHI and GoFSH. Thanks, @KaelynJefferson!
mint-thompson
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a debug log level option to the configuration settings menu to allow a user to toggle the debug level messages that appear in the console.
Testing Instructions: Run jest unit tests and view within browser.
Related Issue: n/a