Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Code Cleanup #1498

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Minor Code Cleanup #1498

merged 4 commits into from
Aug 26, 2024

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Jul 31, 2024

Description: This PR contains minor code cleanup based on things I noticed while preparing the "Developing SUSHI" knowledge sharing session. These include:

  • Simplified the path setting logic now that we know we'll never need choice type renaming
  • Removed an outdated code comment about choice type renaming
  • Removed comment about copying IG scripts (we download them now)
  • Updated the package.json file list to remove files that no longer exist
  • Updated the ANTLR README to refer to all of the grammar files

Testing Instructions: Basic tests to ensure nothing breaks. This passed a regression with a full-year lookback.

@cmoesel cmoesel marked this pull request as ready for review August 1, 2024 14:36
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Copy link
Collaborator

@mint-thompson mint-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Hooray for simplifying ElementDefinition.id!

@cmoesel cmoesel merged commit c1c191b into master Aug 26, 2024
14 checks passed
@cmoesel cmoesel deleted the developing-sushi branch August 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants