Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLA-508 Handle update of immutable pod selector #60

Merged
merged 7 commits into from
Oct 19, 2024

Conversation

murillio4
Copy link
Contributor

No description provided.

…nfigHandlers in DI

- Introduced OperatorConfigHandlers to enable ConfigurationService customization.
- Replaced (Operator) -> Unit with OperatorPostConfigHandler to avoid storing lambdas in Koin.
- Added waitUntilIsDeployed for checking FlaisApplicationCrd deployment state.
- Added generic waitUntil function to wait for any resource condition using HasMetadata.
- Added test to verify deployment is recreated when pod selector is modified.
- Ensures deployment is properly updated and selector labels are correctly handled.
- Added logic to compare pod selectors between actual and desired deployments.
- If pod selectors do not match, the deployment is deleted and recreated to apply the changes.
- Ensures accurate reconciliation when pod selector updates are detected.
…ource

- Added updateAndGetResource function to update a resource, wait for deployment, and retrieve the updated resource.
- Supports custom name selectors with a default based on metadata name.
…match

- Added test to ensure that deployment is updated without recreation when pod selector remains unchanged.
- Asserts that the log does not contain the message indicating pod selector mismatch.
@murillio4 murillio4 added the enhancement New feature or request label Oct 19, 2024
@murillio4 murillio4 merged commit 713a1c3 into main Oct 19, 2024
5 checks passed
@murillio4 murillio4 deleted the feature/handle-immutable-pod-selector-update branch October 19, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant