Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects extension #298

Merged
merged 5 commits into from
Aug 3, 2024
Merged

Conversation

miriamsr
Copy link
Member

@miriamsr miriamsr commented Aug 3, 2024

No description provided.

Copy link
Member

@uvidyadharan uvidyadharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@uvidyadharan uvidyadharan merged commit 5f8d9bc into FIRST-Tech-Challenge:main Aug 3, 2024
5 of 6 checks passed
@miriamsr miriamsr deleted the redirects branch August 3, 2024 01:48
@TheTripleV
Copy link

Note that wpilibsuite/sphinxext-linkcheckdiff no longer works due to internal Sphinx changes. https://github.com/wpilibsuite/frc-docs/blob/main/.github/workflows/CI.yml#L86 is what frc-docs uses now.

@uvidyadharan
Copy link
Member

Note that wpilibsuite/sphinxext-linkcheckdiff no longer works due to internal Sphinx changes. https://github.com/wpilibsuite/frc-docs/blob/main/.github/workflows/CI.yml#L86 is what frc-docs uses now.

Thanks for letting us know @TheTripleV . I implemented a manual diff check of our own in #301 . I didn't want it to do it the way frc-docs does since if you make a change in the same file but don't cause the error the linkchecker will still throw an error. It is a lot messier than your implementation though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants