Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress FNA3D traces by default #203

Open
2 tasks
flibitijibibo opened this issue Apr 9, 2024 · 1 comment
Open
2 tasks

Compress FNA3D traces by default #203

flibitijibibo opened this issue Apr 9, 2024 · 1 comment

Comments

@flibitijibibo
Copy link
Member

flibitijibibo commented Apr 9, 2024

The compression ratio of traces is usually really low (sometimes less than 1%...?!) so we should probably just skip the manual compression step and do this at runtime.

We already have miniz in the repo, so maybe we can just use that? Since the ratio is so low we can prioritize performance and it will still almost certainly be super tiny compared to the uncompressed trace.

  • Compress in FNA3D_Tracing.c
  • Decompress in replay.c
@kg
Copy link
Contributor

kg commented Apr 9, 2024

Oh, I didn't notice miniz. That should definitely do the trick as long as it's not too slow. If it is, we could probably use one of the fast lz* algorithms, I think they're pretty small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants