Skip to content

Commit

Permalink
feat: Use session storage instead of cookies due to memory limitations
Browse files Browse the repository at this point in the history
  • Loading branch information
PintoGideon committed Jun 4, 2024
1 parent cda50e2 commit 0ff793d
Show file tree
Hide file tree
Showing 7 changed files with 51 additions and 45 deletions.
2 changes: 2 additions & 0 deletions src/components/Feeds/FeedView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export default function FeedView() {
queryKey: ["publicFeed", id],
queryFn: () => fetchPublicFeed(id),
enabled: type === "public",
refetchOnMount: true,
});

const {
Expand All @@ -83,6 +84,7 @@ export default function FeedView() {
queryKey: ["authenticatedFeed", id],
queryFn: () => fetchAuthenticatedFeed(id),
enabled: type === "private" && isLoggedIn,
refetchOnMount: true,
});

React.useEffect(() => {
Expand Down
4 changes: 2 additions & 2 deletions src/components/NewLibrary/Cart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const Cart = () => {
cannotDownload,
resetErrors,
recreateState,
clearPathCookie,
clearPathSessionStorage,
} = useOperations();
const { mutate } = handleDownloadMutation;

Expand Down Expand Up @@ -164,7 +164,7 @@ const Cart = () => {
clearFeed();
dispatch(clearDownloadFileStatus(item.payload.data.id));
dispatch(clearDownloadFolderStatus(item.payload.data.id));
clearPathCookie(item.path);
clearPathSessionStorage(item.path, item.payload.data.id);
}}
key={`a-${item.payload.data.id}`}
>
Expand Down
1 change: 1 addition & 0 deletions src/components/NewLibrary/useDownloadHook.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { getFileName } from "../FeedOutputBrowser/FileBrowser";
export const createLinkAndDownload = (url: string, fileName: string) => {
const link = document.createElement("a");
link.href = url;
//link.target = 'blank';
link.download = fileName;
document.body.appendChild(link);
link.click();
Expand Down
82 changes: 44 additions & 38 deletions src/components/NewLibrary/useOperations.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,8 @@ import {
} from "./context/actions";
import { downloadFile } from "./useDownloadHook";
import { isEmpty } from "lodash";
import { useCookies, Cookies } from "react-cookie";

const oneDayToSeconds = 24 * 60 * 60;
const useOperations = () => {
const [_cookies, setCookie] = useCookies();
const cookie = new Cookies();
const router = useContext(MainRouterContext);
const { state, dispatch } = useContext(LibraryContext);
const username = useTypedSelector((state) => state.user.username);
Expand Down Expand Up @@ -64,6 +60,11 @@ const useOperations = () => {
});
};

useEffect(() => {
// recreate state whenever the component first mounts from session storage
recreateState();
}, []);

useEffect(() => {
keepACopyInState();
}, [state.folderDownloadStatus, state.selectedPaths]);
Expand Down Expand Up @@ -95,34 +96,42 @@ const useOperations = () => {
router.actions.clearFeedData();
};

const clearPathCookie = (path: string) => {
const clearPathSessionStorage = (path: string, id: number) => {
const copiedState = { ...state };
const newSelectedPaths = copiedState.selectedPaths.filter((pathObj) => {
return pathObj.path !== path;
});

setCookie("selectedPaths", newSelectedPaths, {
path: "/",
maxAge: oneDayToSeconds,
});
// Delete ids
if (!isEmpty(FolderDownloadTypes)) {
delete copiedState.folderDownloadStatus[id];
}

sessionStorage.setItem("selectedPaths", JSON.stringify(newSelectedPaths));

sessionStorage.setItem(
"folderDownloadStatus",
JSON.stringify(copiedState.folderDownloadStatus),
);
};

const keepACopyInState = () => {
if (!isEmpty(state.folderDownloadStatus)) {
setCookie("folderDownloadStatus", state.folderDownloadStatus, {
path: "/",
maxAge: oneDayToSeconds,
});
sessionStorage.setItem(
"folderDownloadStatus",
JSON.stringify(state.folderDownloadStatus),
);
}

if (!isEmpty(state.selectedPaths)) {
setCookie("selectedPaths", state.selectedPaths, {
path: "/",
maxAge: oneDayToSeconds,
});
sessionStorage.setItem(
"selectedPaths",
JSON.stringify(state.selectedPaths),
);
}
};
const pickDownloadsFromCookie = async (

const pickDownloadsFromSession = async (
selectedPaths: any,
folderDownloadStatus: any,
) => {
Expand All @@ -134,14 +143,11 @@ const useOperations = () => {
if (currentStatus) {
if (currentStatus === FolderDownloadTypes.zippingFolder) {
const data = await checkIfFeedExists(payload);

console.log("Data", data);

if (!data || !data.feed || !data.createdInstance) {
setDownloadErrorState(
payload as FileBrowserFolder,
payload.data.path,
"Error download this folder/file",
"Error downloading this folder/file",
);
} else {
const { feed, createdInstance } = data;
Expand All @@ -168,8 +174,12 @@ const useOperations = () => {

const recreateState = async () => {
const client = ChrisAPIClient.getClient();
const folderDownloadStatus = cookie.get("folderDownloadStatus");
const selectedPaths = cookie.get("selectedPaths");
const folderDownloadStatus = JSON.parse(
sessionStorage.getItem("folderDownloadStatus") || "{}",
);
const selectedPaths = JSON.parse(
sessionStorage.getItem("selectedPaths") || "[]",
);
try {
if (isEmpty(state.selectedPaths) && !isEmpty(selectedPaths)) {
const updatedSelectedPaths = await Promise.all(
Expand All @@ -183,15 +193,13 @@ const useOperations = () => {
return path;
}),
);

dispatch(setSelectedFolderFromCookies(updatedSelectedPaths));

if (
isEmpty(state.folderDownloadStatus) &&
!isEmpty(folderDownloadStatus)
) {
dispatch(setDownloadStatusFromCookies(folderDownloadStatus));
await pickDownloadsFromCookie(
await pickDownloadsFromSession(
updatedSelectedPaths,
folderDownloadStatus,
); // Ensure this awaits the completion
Expand Down Expand Up @@ -253,7 +261,6 @@ const useOperations = () => {
feed = feeds?.[0];
const pluginInstances = await feed?.getPluginInstances({});
const pluginInstancesItems = pluginInstances?.getItems();
console.log("PluginInstanceItems", pluginInstancesItems);
if (pluginInstancesItems) {
createdInstance = pluginInstancesItems[pluginInstancesItems.length - 1];
}
Expand Down Expand Up @@ -315,8 +322,6 @@ const useOperations = () => {

const { id } = pipeline.data;

console.log("Created Instance", createdInstance);

//@ts-ignore
const workflow = await client.createWorkflow(id, {
previous_plugin_inst_id: createdInstance.data.id,
Expand All @@ -339,6 +344,7 @@ const useOperations = () => {
}

const filePath = `home/${username}/feeds/feed_${feed.data.id}/pl-dircopy_${createdInstance.data.id}/pl-pfdorun_${zipInstance.data.id}/data`;

if (status === "finishedSuccessfully") {
const folderList = await client.getFileBrowserFolders({
path: filePath,
Expand All @@ -361,13 +367,13 @@ const useOperations = () => {
const fileToZip = fileItems[0];
await downloadFile(fileToZip);
await feed.delete();
dispatch(
downloadFolderStatus(
payload as FileBrowserFolder,
FolderDownloadTypes.finished,
),
);
}
dispatch(
downloadFolderStatus(
payload as FileBrowserFolder,
FolderDownloadTypes.finished,
),
);
}
}
}
Expand Down Expand Up @@ -433,7 +439,7 @@ const useOperations = () => {
setDownloadErrorState(
payload as FileBrowserFolder,
path,
"Error download this folder/file",
"Error downloading this folder/file",
);
} else {
const { feed, createdInstance } = data;
Expand Down Expand Up @@ -493,7 +499,7 @@ const useOperations = () => {
cannotDownload,
resetErrors,
recreateState,
clearPathCookie,
clearPathSessionStorage,
keepACopyInState,
};
};
Expand Down
3 changes: 0 additions & 3 deletions src/components/NewLibrarySearch/index.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import {
FileBrowserFolder,
PACSFile,
PACSFileList,
PACSSeries,
PACSSeriesList,
UserFile,
UserFileList,
} from "@fnndsc/chrisapi";
import { useState } from "react";
import { useQuery } from "@tanstack/react-query";
Expand Down
2 changes: 1 addition & 1 deletion src/components/Preview/FileDetailView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const FileDetailView = (props: AllProps) => {
setError("Failed to parse the file for dicom tags");
}
};
console.log("Blob", blob);

if (blob) {
reader.readAsArrayBuffer(blob);
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/XtkViewer/XtkViewer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ const XtkViewer = () => {
r.add(secondaryObject);
}

r.onShowtime = function () {
r.onShowtime = () => {
gui = new dat.GUI();

if (viewerMode === "mesh") {
Expand Down

0 comments on commit 0ff793d

Please sign in to comment.