Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: cornerstone dependency #1062

Open
jennydaman opened this issue Feb 11, 2024 · 3 comments
Open

Performance: cornerstone dependency #1062

jennydaman opened this issue Feb 11, 2024 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers

Comments

@jennydaman
Copy link
Collaborator

This is not an important issue.

The cornerstone3D dependency causes large increase in build memory usage, and also slows down first page load even though cornerstone is not used on the "welcome" page.

@jennydaman
Copy link
Collaborator Author

According to benchmarks using Lighthouse:

  • 7674880 reaches "First Contentful Paint" in 6.1s
  • 9a4d1f2 reached "First Contentful Paint" in 9.3s

@PintoGideon PintoGideon self-assigned this Feb 15, 2024
@PintoGideon
Copy link
Collaborator

@jennydaman Thanks for reporting this. Will look into code-splitting and using the vendor chunks feature in vite to get this working.

@jennydaman
Copy link
Collaborator Author

@PintoGideon i think it’s more important to work on other bugs or features. Even though the first-load performance is bad, it doesn’t matter too much since the assets are all cached.

@PintoGideon PintoGideon added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants