Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to correct library card from feed detail tree view #590

Closed
rudolphpienaar opened this issue Aug 12, 2022 · 8 comments
Closed

Navigate to correct library card from feed detail tree view #590

rudolphpienaar opened this issue Aug 12, 2022 · 8 comments
Assignees

Comments

@rudolphpienaar
Copy link
Member

No description provided.

@rudolphpienaar
Copy link
Member Author

Image

@rudolphpienaar
Copy link
Member Author

Need to add the shopping cart to this experience?

@TateDeVito
Copy link
Contributor

TateDeVito commented Sep 12, 2022

Hey @rudolphpienaar - wondering more about this card could I get a description by chance?

Also is this issue tied to the shopping cart issue (#577)?

Thanks!

@PintoGideon
Copy link
Collaborator

PintoGideon commented Sep 12, 2022

Hey there @TateDeVito ,

This issue is a bit more involved but I'll do my best to explain it here. Feel free to reach out for more questions.

When you login into the ChRIS_ui and navigate to the library page, you'll be able to see all your feeds in the Completed Analyses Tab.

Screenshot from 2022-09-12 15-48-03

Screenshot from 2022-09-12 15-46-34

You'll also see the same feeds in a tabular form in the New and Existing Analyses. When you click on the feed name, you will be able to see the detailed view of that feed. This task involves adding a 'button' to the Feed View page which on clicking will navigate to the corresponding feed in the Library Page.

Screenshot from 2022-09-12 15-46-39

Screenshot from 2022-09-12 15-46-52

By clicking a button, you want to navigate to the corresponding feed in the library page.

Screenshot from 2022-09-12 15-46-19

@TateDeVito
Copy link
Contributor

Ok got it thank you @PintoGideon !

So to clarify, this task is to add a button in the feed view (tree format view) that takes you to the library page of that node you are highlighting.

If this is correct, curious where exactly you want the button? Would that be on the side with the "Add ChildNode" and "Add a Pipeline" buttons? And in the same format I assume?

@PintoGideon
Copy link
Collaborator

PintoGideon commented Sep 13, 2022

Yes, add a button to the panel with our other buttons. I think there would be scope for redesigning that panel in the future, but the core functionality of being able to navigate to the Library page is what we are after.

@TateDeVito
Copy link
Contributor

Great. I will try to take a stab at this one. Thanks!

@TateDeVito
Copy link
Contributor

Notes from MOC meeting:

  • Use upload file option to populate new nodes
  • The Cancel button at the end of the "New Analysis" dialog should say Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants