Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pacs Query for oxidicom #1125

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

PintoGideon
Copy link
Collaborator

@PintoGideon PintoGideon commented Mar 22, 2024

Addresses: #1107

This pull request introduces significant enhancements to the PACS retrieval process in ChRIS. The key improvements are as follows:

  • Self-driven PACS Operations: The PACS retrieve, push, and register steps are now entirely self-driven. There is no longer a need to poll PFDCM to monitor the progress of these operations.
  • Decoupling from PFDCM: PFDCM is no longer responsible for tracking the status of retrieve, repack, or register operations.
  • Real-time Registration to CUBE: DICOM files are now registered to CUBE in real-time, ensuring they appear within milliseconds of being received from the PACS. To monitor the progress of a PACS retrieve operation, polling CUBE for the number of files in a series is recommended instead of polling PFDCM.
  • PFDCM remains relevant only for initiating retrieval operations, searching for studies and series, and providing information about the number of DICOM instances in a series.

These changes streamline the PACS retrieval process, improve real-time feedback, and reduce system complexity.

@PintoGideon PintoGideon marked this pull request as draft March 22, 2024 20:08
@PintoGideon PintoGideon marked this pull request as ready for review March 27, 2024 20:31
@PintoGideon PintoGideon changed the title Impelement Pacs Query for oxidicom Implement Pacs Query for oxidicom Mar 27, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 3.84615% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 29.62%. Comparing base (c2d0cd6) to head (6c67fcc).

Files Patch % Lines
src/components/Pacs/components/SeriesCard.tsx 1.20% 82 Missing ⚠️
src/components/Pacs/components/StudyCard.tsx 7.14% 13 Missing ⚠️
src/components/Pacs/pfdcmClient.tsx 0.00% 3 Missing and 1 partial ⚠️
src/components/Preview/FileDetailView.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   28.68%   29.62%   +0.93%     
==========================================
  Files         201      201              
  Lines        6250     6126     -124     
  Branches     1302     1273      -29     
==========================================
+ Hits         1793     1815      +22     
+ Misses       4347     4201     -146     
  Partials      110      110              
Flag Coverage Δ
e2etests 29.62% <3.84%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PintoGideon PintoGideon merged commit 54cad39 into FNNDSC:master Mar 27, 2024
1 check passed
@@ -12,27 +12,28 @@ export interface ImageStatusType {

export interface DataFetchQuery {
SeriesInstanceUID: string;
StudyInstanceUID: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that specifying StudyInstanceUID is necessary for FUJI PACS. I will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants