Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation ubuntu20.04 22.04 #374

Conversation

RoyAmoyal
Copy link
Contributor

@RoyAmoyal RoyAmoyal commented Oct 21, 2024

I have included the necessary files along with a guide for installing and building the project from source on Ubuntu 20.04 and Ubuntu 22.04+.

RoyAmoyal and others added 3 commits October 22, 2024 02:04
@wouter-heerwegh
Copy link
Member

Hi @RoyAmoyal,

Thanks for contributing. I quickly went over the changes and tried to simplify it a bit, by changing the regular setup.sh and build.sh files, so step 3 should no longer be required. Also, after building with the docker container, is step 6 needed? Are you not able to launch the project directly?

@RoyAmoyal
Copy link
Contributor Author

RoyAmoyal commented Oct 22, 2024

Hi @RoyAmoyal,

Thanks for contributing. I quickly went over the changes and tried to simplify it a bit, by changing the regular setup.sh and build.sh files, so step 3 should no longer be required. Also, after building with the docker container, is step 6 needed? Are you not able to launch the project directly?

Great idea with setup.sh and build.sh.

About step 6, yes, unfortunately, you need to run the command (only done once) to build the project with Unreal. I have tested twice on different computers.
After that, you can launch it normally. (This solution is also mentioned in #365 )

@wouter-heerwegh
Copy link
Member

Hmm okay, would you be able to share the error logs when not using step 6 if you still have them? Is this where it complains about the uint64_t?

Other than that the changes look good to me.

@RoyAmoyal
Copy link
Contributor Author

RoyAmoyal commented Oct 22, 2024

Hmm okay, would you be able to share the error logs when not using step 6 if you still have them? Is this where it complains about the uint64_t?

Other than that the changes look good to me.

Without running step 6, even with the modified setup.sh/build.sh for Ubuntu 20.04/22.04, you'll still encounter the same error as in #365 : "Engine modules are out of date."

If you skip the modified setup.sh/build.sh but run step 6, the error will still occur.

You need both the modified setup.sh/build.sh and step 6 to successfully build the project with Unreal.

The error that related to uint64_t is related to packaging the project with Unreal, I will create a PR or a solution in the issues section. But it's not related to building from source.

@wouter-heerwegh
Copy link
Member

The modules should indeed be out of date, but when AirLib is correctly built, Unreal Engine should be able to build the AirLib module itself. If it doesn't and you get the message that you should build from source, than there should be some more information logged in the terminal you used to launch the project. I would assume it didn't work before because of the pthread symbols being available in the library, but with the docker container, it shouldn't contain them.

@RoyAmoyal
Copy link
Contributor Author

RoyAmoyal commented Oct 22, 2024

I believe the issue is related to the default Unreal Editor build configuration. A team member in our team confirmed that he also encountered the error when trying to build the project with the Unreal Editor gui or when attempting to open the .uproject file directly without using the command from step 6 (but correctly build the AirLib with the docker).

Step 6 provides a way to ensure the correct build configuration (e.g., Development mode and Linux platform). We should keep this in the documentation because anyone building from source will likely run into this error with the existing instructions and default configuration.

You can also refer to the same solution here #365 (comment)

@wouter-heerwegh
Copy link
Member

I'm asking, because we didn't run into this issue back on Ubuntu 18.04, and I remember when I initially ran into this issue, that it might be that the executable does not work for every system. But should be okay, for general releases I will just use Windows anyway.

I'm going to change the the documentation slightly, since the changes only impact the way AirSim should be built.

@wouter-heerwegh
Copy link
Member

Hi @RoyAmoyal,

What are your thoughts on the last changes to the documentation?

@wouter-heerwegh wouter-heerwegh force-pushed the fix_installation_ubuntu20.04_22.04 branch from d6025b7 to a823958 Compare October 22, 2024 17:14
@RoyAmoyal
Copy link
Contributor Author

Hi @RoyAmoyal,

What are your thoughts on the last changes to the documentation?

Looks great!

Copy link
Member

@wouter-heerwegh wouter-heerwegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks good to me then, let's merge it.

@wouter-heerwegh wouter-heerwegh merged commit ad74992 into FS-Driverless:master Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants