Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Model Generation, data generation for custom blocks via blockstates. #268

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

Fellteros
Copy link

A guide to block model generation and to data generation for custom blocks. I also added a new page for Item Model Generation, which is unfinished for now, because I don't have enough experience with that. Feel free to expand that.
The page should have not any spelling/grammar mistakes, though English isn't my main language. Some choices of words may be a little strange.

@Fellteros Fellteros requested a review from a team as a code owner January 18, 2025 17:19
Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for nimble-elf-d9d491 failed.

Name Link
🔨 Latest commit 69c26df
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/678e80cb2a0bf30008ac02ba

@its-miroma its-miroma added new-content A new page or set of pages stage:verification This should be verified labels Jan 18, 2025
@Fellteros Fellteros requested a review from a team as a code owner January 18, 2025 18:50
@Fellteros
Copy link
Author

thanks for the contribution! left a few comments here and there. you don't have to rehash what's in other articles, can just link to them ^^

All files should be changed according to your suggestions. I also added you to the author list.

Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite alot of changes needed, very well structured so far.

The BlockFamily should be referenced/code shown in the page, its not mentioned enough.

Also run a quick spell check and grammar using LanguageTool, please dont use line break HTML elements either, a new line gap can suffice in all cases.

develop/data-generation/block-models.md Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
@IMB11 IMB11 added stage:cleanup This should be cleaned up and removed stage:verification This should be verified labels Jan 19, 2025
@Fellteros
Copy link
Author

All changes should be present, thanks for all corrections.

@Fellteros Fellteros requested a review from IMB11 January 19, 2025 15:42
natri0

This comment was marked as off-topic.

@IMB11

This comment was marked as resolved.

@Fellteros
Copy link
Author

All things should be complete now (I hope)

develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
develop/data-generation/block-models.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-content A new page or set of pages stage:cleanup This should be cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants