Add AFTER_CLIENT_WORLD_CHANGE #4173
Conversation
...-v1/src/client/java/net/fabricmc/fabric/api/entity/event/client/ClientWorldChangeEvents.java
Outdated
Show resolved
Hide resolved
modmuss50
added
enhancement
modmuss50
added
last call
| /** | ||
| * An event which is called after the client world has been changed. | ||
| */ | ||
| public static final Event<AfterClientWorldChange> AFTER_CLIENT_WORLD_CHANGE = EventFactory.createArrayBacked(AfterClientWorldChange.class, callbacks -> (client, world) -> { |
There was a problem hiding this comment.
I wonder if this event should be named 'load' to match the corresponding event in the ServerWorldEvents class. The parameters are even similar, being a server or client and the respectively-sided world. The main difference is that the world here can be null, which is represented by an unload event in the ServerWorldEvents class instead.
...-v1/src/client/java/net/fabricmc/fabric/api/client/event/lifecycle/v1/ClientWorldEvents.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * An event which is called after the client world has been changed. | ||
| */ | ||
| public static final Event<AfterClientWorldChange> AFTER_CLIENT_WORLD_CHANGE = EventFactory.createArrayBacked(AfterClientWorldChange.class, callbacks -> (client, world) -> { |
There was a problem hiding this comment.
I believe this event should be called LOAD due to these two reasons:
- To be consistent with the
ServerWorldEventsclass. - This event is also called on the initial world load, and it doesn't make sense to be called
AFTER_CLIENT_WORLD_CHANGE.
Also, I assume this event only fires once on world change, not once null then once with the new world?
There was a problem hiding this comment.
That makes sense, I have completed the modifications.
There was a problem hiding this comment.
I dont think load is correct at all, when joining a server, or switching a world you arent loading (from the disk) the world at all.
There was a problem hiding this comment.
I have reverted its name now.
| private ClientWorldEvents() { | ||
| } |
There was a problem hiding this comment.
I don't think this is going to pass the checkstyle? The constructor should be between the field and the interface.
There was a problem hiding this comment.
I'm sorry, but I wrote it by imitating other classes within the same package. If there are any issues, could you provide more information?
There was a problem hiding this comment.
Try running the check task (./gradlew check). Typically GitHub Actions would provide context as well, but a maintainer would need to approve the run first.
There was a problem hiding this comment.
Thank you for your guidance. I received a BUILD SUCCESSFUL after running the check task.
|
Now that I think about this, what's the difference between this event and |
|
Switching dimensions changes the |
fishshi
force-pushed
the
feature/AFTER_CLIENT_WORLD_CHANGE
branch
from
9ab01ea
to
4070a1d
Compare
* add AFTER_CLIENT_WORLD_CHANGE * fix * move * add description to README and change class to final with a private constructor * revert the event name
* add AFTER_CLIENT_WORLD_CHANGE * fix * move * add description to README and change class to final with a private constructor * revert the event name
Add an event for the current ClientWorld being updated.
Fixes #3714