Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Smooth Boot #305

Closed
Madis0 opened this issue Apr 29, 2022 · 12 comments
Closed

Remove Smooth Boot #305

Madis0 opened this issue Apr 29, 2022 · 12 comments
Labels
mod New Fabric mod to include remove Mods that could be removed

Comments

@Madis0
Copy link
Member

Madis0 commented Apr 29, 2022

Mod name

Smooth Boot

Curseforge link

No response

Other links

No response

What it does

Optimizes startup and resource usage

Why should it be in the modpack

Smooth Boot claims that they are compatible with each other
https://github.com/UltimateBoomer/mc-smoothboot/wiki#lazydfu

Why shouldn't it be in the modpack

People claim it is useless when LazyDFU exists. Need more data to prove that.

Currently LazyDFU claims to be superior, but Smooth Boot says it can still can optimize the resource usage (threads).

Categories

New feature

Additional details

UltimateBoomer/mc-smoothboot#38

@Madis0 Madis0 added mod New Fabric mod to include feedback/testers wanted Issues that could use more feedback from the users replace Replaces an existing mod remove Mods that could be removed and removed mod New Fabric mod to include replace Replaces an existing mod labels Apr 29, 2022
@Madis0 Madis0 added on hold Mods that are waiting for something before inclusion feedback/testers wanted Issues that could use more feedback from the users and removed feedback/testers wanted Issues that could use more feedback from the users on hold Mods that are waiting for something before inclusion labels May 18, 2022
@Madis0
Copy link
Member Author

Madis0 commented May 18, 2022

So, according to the dev in the issue above it should still reduce some game stutters. I still want testers who can compare normal FO and without Smooth Boot on their machine.

@Uranite
Copy link

Uranite commented May 29, 2022

In my testing upon world join there is less stutter with smooth boot and it's also less stuttery when flying around loading new chunks with smooth boot
But I think smooth boot might cause this issue where new chunks load really slowly and I could consistently replicate this, it might be because there is less thread for whatever the chunk generation is on https://github.com/UltimateBoomer/mc-smoothboot/wiki/Configuration~-Fabric-1.16+

@Madis0
Copy link
Member Author

Madis0 commented Jul 4, 2022

Well, less stutter is more important than slighly slower chunks (as Starlight makes them faster either way). Closing the issue.

@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2022
@Madis0 Madis0 added rejected Mods and changes that will not be added and removed feedback/testers wanted Issues that could use more feedback from the users labels Jul 4, 2022
@Madis0 Madis0 reopened this Dec 28, 2022
@Madis0 Madis0 removed the rejected Mods and changes that will not be added label Dec 28, 2022
@Madis0
Copy link
Member Author

Madis0 commented Dec 28, 2022

@Julienraptor01 do you have speed/perf tests? E g. boot time vs CPU usage with and without the mod.

@Madis0 Madis0 added mod New Fabric mod to include feedback/testers wanted Issues that could use more feedback from the users labels Dec 28, 2022
@Kichura
Copy link
Member

Kichura commented Dec 28, 2022

From a personal point of view; Using smooth boot itself is already catastrophic from the get-go due to how complicated the configuration is and that it has a possibility of breaking on other devices since the config cannot be synced perfectly without compromises.

@Madis0
Copy link
Member Author

Madis0 commented Dec 28, 2022

Considering how I don't bundle a config for it at all and if I did, I could provide only the necessary subset of the json, I'd say that is a weak argument.

On the other hand, if you can benchmark the game with and without the mod as I suggested, that would bring a better point whether to keep it or not.

@Julienraptor01
Copy link
Contributor

Julienraptor01 commented Dec 28, 2022

Considering how I don't bundle a config for it at all and if I did, I could provide only the necessary subset of the json, I'd say that is a weak argument.

On the other hand, if you can benchmark the game with and without the mod as I suggested, that would bring a better point whether to keep it or not.

related to the config, the mod doesn't do what the wiki tell it does
UltimateBoomer/mc-smoothboot#34

@Madis0
Copy link
Member Author

Madis0 commented Dec 29, 2022

Planned to be removed now for the following reasons:

  • Positive effects are likely mostly nullified by LazyDFU already, aka LazyDFU provides better results with less drawbacks
  • The mod may actually harm performance at the expense of "keeping it more stable" (actual claim made in the wiki), though the latter is also not verified by majority that it actually helps
  • The mod seems to require per-device configuration to help with stability, defaults don't seem to be enough. Per-device configuration is infeasible to do in the modpack
  • Claims from other people that the mod harms performance/is redundant

@Julienraptor01
Copy link
Contributor

Planned to be removed now for the following reasons:

  • Positive effects are likely mostly nullified by LazyDFU already, aka LazyDFU provides better results with less drawbacks
  • The mod may actually harm performance at the expense of "keeping it more stable" (actual claim made in the wiki), though the latter is also not verified by majority that it actually helps
  • The mod seems to require per-device configuration to help with stability, defaults don't seem to be enough. Per-device configuration is infeasible to do in the modpack
  • Claims from other people that the mod harms performance/is redundant

I think we should have an article in the wiki that present mods that could help specific players but need manual config

@Madis0
Copy link
Member Author

Madis0 commented Dec 29, 2022

I think we should have an article in the wiki that present mods that could help specific players but need manual config

Fabulously-Optimized/wiki#26
Feel free to contribute.

@Madis0
Copy link
Member Author

Madis0 commented Jan 2, 2023

Done in 4.6.0-beta.1.
As it is in a beta, I can still be persuaded to revert this, in case someone can prove their perf is actually worse compared to alpha 13. But otherwise, good riddance 😄

@Madis0
Copy link
Member Author

Madis0 commented Mar 19, 2023

Found someone who said they actually benefit from this: https://discord.com/channels/859124104644788234/1087042168599871578

But I'm still wary of adding it back because the config is still not device-specific... 🤔

@Madis0 Madis0 closed this as completed Mar 24, 2023
@Madis0 Madis0 removed the feedback/testers wanted Issues that could use more feedback from the users label Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include remove Mods that could be removed
Projects
None yet
Development

No branches or pull requests

4 participants