Skip to content

chore(*): use latest atat, with new urc channel #1

chore(*): use latest atat, with new urc channel

chore(*): use latest atat, with new urc channel #1

Triggered via pull request September 12, 2023 09:20
Status Failure
Total duration 1m 4s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 8 warnings
Build & Test
a value is required for '--features <FEATURES>' but none was supplied
Build & Test
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
Build & Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
this expression creates a reference which is immediately dereferenced by the compiler: ublox-short-range/src/command/edm/urc.rs#L62
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ublox-short-range/src/command/edm/urc.rs:62:77 | 62 | defmt::error!("[Parse URC Start/End byte Error] {:?}", LossyStr(&resp)); | ^^^^^ help: change this to: `resp` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ublox-short-range/src/command/custom_digest.rs#L70
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ublox-short-range/src/command/custom_digest.rs:70:51 | 70 | defmt::trace!("Digest {:?}", LossyStr(&buf)); | ^^^^ help: change this to: `buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ublox-short-range/src/command/custom_digest.rs#L21
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ublox-short-range/src/command/custom_digest.rs:21:47 | 21 | defmt::trace!("Digest {:?}", LossyStr(&buf)); | ^^^^ help: change this to: `buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
use of `default` to create a unit struct: ublox-short-range/src/client.rs#L226
warning: use of `default` to create a unit struct --> ublox-short-range/src/client.rs:226:51 | 226 | buffers.split_blocking(tx, EdmDigester::default(), atat::Config::default()); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
field `urc_channel` is never read: ublox-short-range/src/client.rs#L184
warning: field `urc_channel` is never read --> ublox-short-range/src/client.rs:184:5 | 156 | pub struct UbloxClient< | ----------- field in this struct ... 184 | urc_channel: &'buf AtUrcCh, | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unneeded unit expression: ublox-short-range/src/wifi/tcp_stack.rs#L222
warning: unneeded unit expression --> ublox-short-range/src/wifi/tcp_stack.rs:222:33 | 222 | ... () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/