Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*): bump embedded-hal to rc.1 #65
chore(*): bump embedded-hal to rc.1 #65
Changes from all commits
e508efa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 111 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this argument is passed by value, but not consumed in the function body
Check warning on line 126 in ublox-short-range/src/client.rs
GitHub Actions / clippy
use Option::map_or instead of an if let/else
Check warning on line 152 in ublox-short-range/src/client.rs
GitHub Actions / clippy
item name ends with its containing module's name
Check warning on line 182 in ublox-short-range/src/client.rs
GitHub Actions / clippy
unnecessary structure name repetition
Check warning on line 213 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 301 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 306 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 327 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 340 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 378 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 424 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 472 in ublox-short-range/src/client.rs
GitHub Actions / clippy
the function has a cognitive complexity of (45/25)
Check warning on line 522 in ublox-short-range/src/client.rs
GitHub Actions / clippy
consider adding a `;` to the last statement for consistent formatting
Check warning on line 539 in ublox-short-range/src/client.rs
GitHub Actions / clippy
consider adding a `;` to the last statement for consistent formatting
Check warning on line 570 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 653 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 653 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 653 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 653 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 653 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 657 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 657 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 657 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 657 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 668 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 668 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 668 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 672 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 672 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 676 in ublox-short-range/src/client.rs
GitHub Actions / clippy
this match arm has an identical body to another arm
Check warning on line 684 in ublox-short-range/src/client.rs
GitHub Actions / clippy
consider adding a `;` to the last statement for consistent formatting
Check warning on line 687 in ublox-short-range/src/client.rs
GitHub Actions / clippy
consider adding a `;` to the last statement for consistent formatting
Check warning on line 761 in ublox-short-range/src/client.rs
GitHub Actions / clippy
wildcard matches only a single variant and will also match any future added variants
Check warning on line 808 in ublox-short-range/src/client.rs
GitHub Actions / clippy
wildcard matches only a single variant and will also match any future added variants
Check warning on line 870 in ublox-short-range/src/client.rs
GitHub Actions / clippy
unnecessary boolean `not` operation
Check warning on line 895 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 906 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 918 in ublox-short-range/src/client.rs
GitHub Actions / clippy
item in documentation is missing backticks
Check warning on line 919 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 932 in ublox-short-range/src/client.rs
GitHub Actions / clippy
use Option::map_or instead of an if let/else
Check warning on line 935 in ublox-short-range/src/client.rs
GitHub Actions / clippy
item in documentation is missing backticks
Check warning on line 940 in ublox-short-range/src/client.rs
GitHub Actions / clippy
docs for function returning `Result` missing `# Errors` section
Check warning on line 956 in ublox-short-range/src/client.rs
GitHub Actions / clippy
use Option::map_or instead of an if let/else