Skip to content

feature(*): Full async implementation #40

feature(*): Full async implementation

feature(*): Full async implementation #40

GitHub Actions / clippy succeeded Jul 18, 2024 in 1s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 74 in src/asynch/network.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
  --> src/asynch/network.rs:59:13
   |
59 | /             match embassy_futures::select::select(
60 | |                 self.urc_subscription.next_message_pure(),
61 | |                 self.ch.wait_for_wifi_state_change(),
62 | |             )
...  |
73 | |                 _ => {}
74 | |             }
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
   = note: `#[warn(clippy::single_match)]` on by default
help: try
   |
59 ~             if let embassy_futures::select::Either::First(event) = embassy_futures::select::select(
60 +                 self.urc_subscription.next_message_pure(),
61 +                 self.ch.wait_for_wifi_state_change(),
62 +             )
63 +             .await {
64 +                 #[cfg(feature = "edm")]
65 +                 let Some(event) = event.extract_urc() else {
66 +                     continue;
67 +                 };
68 + 
69 +                 self.handle_urc(event).await?;
70 +             }
   |

Check warning on line 151 in src/asynch/control.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/asynch/control.rs:151:13
    |
151 |             urc_channel: urc_channel,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urc_channel`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
    = note: `#[warn(clippy::redundant_field_names)]` on by default