Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files.json shouldn't use $autoIncrement #63

Open
3vorp opened this issue Sep 26, 2024 · 0 comments
Open

files.json shouldn't use $autoIncrement #63

3vorp opened this issue Sep 26, 2024 · 0 comments
Labels
difficulty hard evolution not an issue, but a future evolution for next version low priority

Comments

@3vorp
Copy link
Contributor

3vorp commented Sep 26, 2024

files.json currently uses the $autoIncrement feature of Firestorm, which it really shouldn't for a few reasons:

  • The key name is insignificant
  • Can lead to key collisions if two requests are made too close to each other
  • Inconsistent with all other collections
  • Can be confused with add-on IDs (not as much of an issue but still)

Since $autoKey is already enabled, API changes would probably be fairly minimal (since the key was never significant to begin with)—the main thing would be switching the JSON and the config and making sure nothing breaks.

@3vorp 3vorp added low priority difficulty hard evolution not an issue, but a future evolution for next version labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty hard evolution not an issue, but a future evolution for next version low priority
Projects
None yet
Development

No branches or pull requests

1 participant