Fix: sk_SK street names #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devicebusy
force-pushed
the
sk-provider-fixes
branch
from
6103737
to
4c3ed34
Compare
|
Please review the contribution guide (see pr template) |
localheinz
force-pushed
the
sk-provider-fixes
branch
from
4c3ed34
to
b20b868
Compare
localheinz
added
bug
localheinz
approved these changes
Sep 3, 2023
|
This looks good to me - do you have any objections? |
The code itself looks ok but i'd rather see the locale contents covered by a test |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
|
@pimjansen Hello, I'd like to reopen and finalize this Pull Request. What specific test would you like to see? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Fixed an issue with sk_SK street names generation (resolve #672)
Author's checklist
Summary of changes
Added a list of real SK streets, fixed street name format
Review checklist