Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve address provider for en_NG locale #807

Closed
wants to merge 4 commits into from
Closed

Improve address provider for en_NG locale #807

wants to merge 4 commits into from

Commits on Nov 8, 2023

  1. Improve addressing for the en_NG locale 

    - Postcodes in Nigeria are strictly made up of 6 digits. The `$postcode` variable has been updated to reflect that.
- Replaced 'county' with 'state' - which is the actual term used to refer to the major sub-administrative governments directly below the Federal.
- City names in Nigeria do not require a suffix. Hence, the array has been left empty.
- It's common to see street names in Nigeria with prefixes such as 'Chief', 'General', 'Rev.', 'Bishop'. The street name format has been updated to reflect this.
- 'Region' in Nigeria typically refers to the political regional divisions of the country, and not cities. Hence, `cityName` has been added (instead) to reflect actual city names, and `region` has been updated to reflect the political regional divisions of Nigeria.
    @chrisidakwo
    Ekojoka Christolight Idakwo authored and chrisidakwo committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    391fbb7 View commit details
    Browse the repository at this point in the history

  2. Fix code format

    @chrisidakwo
    chrisidakwo committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    914e26f View commit details
    Browse the repository at this point in the history

  3. Add back the county() method for devs already using it

    @chrisidakwo
    chrisidakwo committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    fe7ca25 View commit details
    Browse the repository at this point in the history

  4. Modified the accessors for static variables and made 'county' a stati… 

    …c method
    @chrisidakwo
    chrisidakwo committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    6632895 View commit details
    Browse the repository at this point in the history