Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 Support #904

Open
wants to merge 3 commits into
base: 1.23
Choose a base branch
from
Open

PHP 8.4 Support #904

wants to merge 3 commits into from

Conversation

Jubeki
Copy link

@Jubeki Jubeki commented Oct 3, 2024

What is the reason for this PR?

  • A new feature
  • Fixed an issue

Author's checklist

Summary of changes

  • Adds PHP 8.4 to Test Matrix
  • Add explicit nullable declarations to remove PHP 8.4 deprecations.
  • Add nullable_type_declaration_for_default_null_value to Coding Standards

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

@Jubeki Jubeki marked this pull request as ready for review October 3, 2024 10:00
@Jubeki Jubeki changed the title [1.23] PHP 8.4 Support PHP 8.4 Support Oct 3, 2024
@pimjansen
Copy link

Thanks! Will review later. Initially it all looks fine

@Jubeki
Copy link
Author

Jubeki commented Oct 3, 2024

I think the Static analysis / Psalm failure is unrelated to this PR.

@crynobone crynobone mentioned this pull request Oct 4, 2024
Draft
8 tasks
@pimjansen
Copy link

I think the Static analysis / Psalm failure is unrelated to this PR.

Well im not even getting them locally indeed.

@pimjansen
Copy link

@localheinz you got an idea what this could be? Also the error makes no direct sense to me at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crynobone crynobone crynobone approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jubeki @pimjansen @crynobone