Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Moved messaging related methods to separate module #6

Merged
merged 3 commits into from
Jun 18, 2024
Merged

BREAKING CHANGE: Moved messaging related methods to separate module #6

merged 3 commits into from
Jun 18, 2024

Conversation

hchristine
Copy link
Collaborator

@hchristine hchristine commented Jun 14, 2024 •
edited by shahen94
Loading

Moving pubsub to the Messaging service.
Before

client.publish('topic', 'data');
client.subscribe(topic', (data) => {
  // ...
});
client.unsubscribe('topic');

After

client.messaging.publish('topic', 'data');
client.messaging.subscribe(topic', (data) => {
  // ...
});
client.messaging.unsubscribe('topic');

@shahen94 shahen94 added the core label Jun 14, 2024
@github-actions github-actions bot requested a review from shahen94 June 14, 2024 11:23
@shahen94 shahen94 added the documentation Improvements or additions to documentation label Jun 18, 2024
@shahen94 shahen94 changed the title feat(Messaging): Moved messaging related methods to separate module BREAKING CHANGE: Moved messaging related methods to separate module Jun 18, 2024
@shahen94 shahen94 merged commit c5df836 into main Jun 18, 2024
3 checks passed
@shahen94 shahen94 deleted the refactor/messaging branch June 18, 2024 13:02
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
5a840f9 
# [2.0.0](v1.5.0...v2.0.0) (2024-06-18)

### Bug Fixes

* **Messaging:** Fix memory leak on unsubscribe ([b0075ac](b0075ac))
* **Messaging:** fix messaging publish, subscribe, unsubscribe ([85327c8](85327c8))

* Merge pull request #6 from Famcache/refactor/messaging ([c5df836](c5df836)), closes [#6](#6)

### Features

* **Messaging:** Moved messaging related methods to separate module ([4636c30](4636c30))

### BREAKING CHANGES

* Moved messaging related methods to separate module
@shahen94
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahen94 shahen94 Awaiting requested review from shahen94

Assignees

@shahen94 shahen94

Labels
core documentation Improvements or additions to documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hchristine @shahen94