-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SmileParser getValueAsString() issue with JsonToken.FIELD_NAME #540
SmileParser getValueAsString() issue with JsonToken.FIELD_NAME #540
Conversation
…FIELD_NAME and tentative bugfix.
Ok I'll go over the PR; I think it makes sense overall. But one process thing we need before I can merge the fix (assuming review goes fine); unless already done, we'd need a CLA. It's here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and only needs to be sent one before the first contribution is merged (good for all future PRs). |
Just emailed my signed CLA |
CLA received. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; will extend a bit to handle other formats too.
Ok: added tests to ensure all 5 format backends work (as well as test for Thank you for reporting this @johhud1 and submitting a good fix for Smile case. |
Test updates to reproduce the issue and naive fix attempt for #541