Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

better multiset serialization / deserialization #51

Closed
devinrsmith opened this issue Oct 16, 2014 · 4 comments
Closed

better multiset serialization / deserialization #51

devinrsmith opened this issue Oct 16, 2014 · 4 comments

Comments

@devinrsmith
Copy link

Currently, multisets' serialization size is proportional to Multiset.size() as opposed to Multiset.entrySet().size().

For example, if I have do Multiset.setCount("my_key", 1000), "my_key" is repeated 1000 times in the output. It would be much more appropriate if it behaved liked Map<String, Integer>.

@cowtowncoder
Copy link
Member

Can this be changed without breaking backwards compatibility? Especially considering that values themselves may be of any type, including numbers, Objects, Strings...

@devinrsmith
Copy link
Author

I'm not familiar w/ the intricacies of jackson serialization / deserialization. I'd be pretty surprised if there is widespread use of serializing Multisets (using the existing jackson library)... I would have guessed a lot of other people would be bringing up this exact issue if they were using it. Does jackson ever create hard-breaks in backwards compatibility?

@cowtowncoder
Copy link
Member

Typically the way changes like this are handled is by introducing a new on/off Feature (for module or component) which defaults to old behavior, and can be changed to support new handling.
But there are limited number of cases where we have just changed the setting, if we really think there is very low risk of problems.

This might be something to bring up on dev mailing list, esp. since there may be multiple ways data could be structured.

But I can definitely see why change would be useful here; it's just a question of how to best improve the situation.

@cowtowncoder
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants