Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Friend 일부 리팩터링- #67 #93

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[Refactor] Friend 일부 리팩터링- #67 #93

merged 1 commit into from
Dec 19, 2023

Conversation

Juser0
Copy link
Member

@Juser0 Juser0 commented Dec 19, 2023 •
edited by eunki96
Loading

📋 이슈 번호

🛠 구현 사항

  • 기존의 Friend 요소들을 고치려고 하였으나, 엔티티 자체의 결합도가 너무 높아서 새로 작업하기로 하여 일부만 진행하였습니다

📚 기타

@Juser0 Juser0 added the ♻️ Refactoring 코드 동작 방식 변경 label Dec 19, 2023
@Juser0 Juser0 requested a review from eunki96 December 19, 2023 14:29
@Juser0 Juser0 self-assigned this Dec 19, 2023
eunki96
eunki96 reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@eunki96 eunki96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Controller 메서드 일부 → Service 단으로 내림
  • Friend 필드 → friendNo, user[follower], followee, friendMemo
  • for → stream
  • AllArgsConstructor + Builder → 생성자 Builder

eunki96
eunki96 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@eunki96 eunki96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 12.21 목 회의 후 or 금 단기 계획
  • 토요일 → 대면 회의

@eunki96 eunki96 merged commit 1fc3ef2 into main Dec 19, 2023
2 checks passed
@eunki96 eunki96 deleted the juwon/#67 branch December 19, 2023 22:43
@eunki96 eunki96 restored the juwon/#67 branch December 19, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunki96 eunki96 eunki96 approved these changes

Assignees

@Juser0 Juser0

Labels
♻️ Refactoring 코드 동작 방식 변경
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juser0 @eunki96