Added todo comments.

Felix-CodingClimber · Feb 10, 2024 · 41b54da · 41b54da
1 parent 3d63a85
commit 41b54da
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/DotNetElements.Core/Core/Result/CrudResult.cs b/src/DotNetElements.Core/Core/Result/CrudResult.cs
@@ -8,6 +8,11 @@ public enum CrudError
 	ConcurrencyConflict,
 }
 
+// todo make abstract base class with TErrorCodeEnum as type parameter
+// and where TErrorCodeEnum is enum constraint
+// Inherited classes can provide custom error codes
+// Error codes should be used to communicate errors back to client
+
 public readonly partial struct CrudResult : IResult
 {
 	public bool IsFail { get; }

diff --git a/src/DotNetElements.Web.MudBlazor/Extensions/ServiceCollectionExtensions.cs b/src/DotNetElements.Web.MudBlazor/Extensions/ServiceCollectionExtensions.cs
@@ -10,6 +10,11 @@ public static IServiceCollection AddCrudService<TKey, TModel, TDetails, TEditMod
         where TDetails : ModelDetails
         where TEditModel : IMapFromModel<TEditModel, TModel>, ICreateNew<TEditModel>
     {
+        // todo consider using the options pattern
+        // Action<CrudOptions<TModel>> configureOptions as parameter
+        // Call services.Configure(configureOptions);
+        // In CrudService inject a IOptions<CrudOptions<TModel>>
+
         services.AddScoped<ICrudService<TKey, TModel, TDetails, TEditModel>>(provider => new CrudService<TKey, TModel, TDetails, TEditModel>(
             provider.GetRequiredService<ISnackbar>(),
             provider.GetRequiredService<HttpClient>(),