Follow up changes to Runic formatting #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fredrikekre
commented
Oct 31, 2024
•
fredrikekre
commented
- Add commit to blame ignore list
- Mention Runic formatting in the CHANGELOG.md
- Run Runic check on CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1099 +/- ##
=======================================
Coverage 93.57% 93.57%
=======================================
Files 39 39
Lines 6074 6074
=======================================
Hits 5684 5684
Misses 390 390 ☔ View full report in Codecov by Sentry. |
fredrikekre
force-pushed
the
fe/runic-ignore
branch
from
bd2c958
to
d77f069
Compare
fredrikekre
changed the title
|
Really nice with having Runic here! I think some instructions for how to run locally (both as git hook and without) in CONTRIUBTING would be helpful. |
fredrikekre
force-pushed
the
fe/runic-ignore
branch
from
ea78620
to
d6e43f4
Compare
|
Added some info to CONTRIBUTING.md, perhaps you can try it out? |
KnutAM
reviewed
Oct 31, 2024
- Add commit to blame ignore list - Mention Runic formatting in the CHANGELOG.md - Run Runic check on CI - Add runic-pre-commit to pre-commit configuration - Add information about Runic and pre-commit to CONTRIBUTING.md
fredrikekre
force-pushed
the
fe/runic-ignore
branch
from
d6e43f4
to
7cf448e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.